msyavuz commented on code in PR #32514:
URL: https://github.com/apache/superset/pull/32514#discussion_r1999069240
##########
superset-frontend/src/components/Select/styles.tsx:
##########
@@ -39,35 +38,41 @@ export const StyledContainer = styled.div<{ headerPosition:
string }>`
`}
`;
-export const StyledSelect = styled(AntdSelect, {
+export const StyledSelect = styled(Select, {
shouldForwardProp: prop => prop !== 'headerPosition' && prop !== 'oneLine',
})<{ headerPosition?: string; oneLine?: boolean }>`
${({ theme, headerPosition, oneLine }) => `
flex: ${headerPosition === 'left' ? 1 : 0};
- && .ant-select-selector {
- border-radius: ${theme.sizeUnit}px;
+ line-height: ${theme.sizeXL}px;
+
+ && .antd5-select-selection-search {
+ left: 0px;
+ }
+
+ && .antd5-select-selection-item, .antd5-select-selection-placeholder {
+ max-height: ${theme.sizeXL}px;
}
- // Open the dropdown when clicking on the suffix
- // This is fixed in version 4.16
- .ant-select-arrow .anticon:not(.ant-select-suffix) {
- pointer-events: none;
+ .antd5-select-selection-item::after {
+ height: 0;
+ display: block !important;
}
.select-all {
+ border-radius: 0;
border-bottom: 1px solid ${theme.colors.grayscale.light3};
Review Comment:
This is one of the two usages of color with Ant Design's Select. This one is
basically the divider between `Select all` and other options. I will check the
other one to see if we can get rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
