LevisNgigi commented on PR #32767:
URL: https://github.com/apache/superset/pull/32767#issuecomment-2744279259

   > Hey @LevisNgigi Thanks for taking care of this! I see the UI is the one 
doing the aggregation, we have some charts like `Pivot Table` that already have 
a similar control so you could refer to that since it supports more aggregation 
methods. However, I would prefer not having the UI computing these values, and 
luckily for us we already support `PostProcessing` rules as [you can see 
here](https://github.com/apache/superset/blob/master/superset/utils/pandas_postprocessing/aggregate.py),
 these are usually used through an operator, we already have one [for 
Aggregation 
](https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/query/types/PostProcessing.ts#L76),
 the `BigNumberWithTrendline` chart already [make use of several of 
these](https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/buildQuery.ts#L43),
 so you would only need to inject some logic here to dynamically b
 uild the proper object and let the backend do the rest along with the control 
with more methods?
   
   @Antonio-RiveroMartnez Thank you for the feedback will be looking into it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to