LevisNgigi commented on code in PR #32767:
URL: https://github.com/apache/superset/pull/32767#discussion_r2010653186


##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/customControls.tsx:
##########
@@ -61,6 +61,30 @@ const xAxisSortVisibility = ({ controls }: { controls: 
ControlStateMapping }) =>
   ensureIsArray(controls?.groupby?.value).length === 0 &&
   ensureIsArray(controls?.metrics?.value).length === 1;
 
+export const aggregationControl = {

Review Comment:
   I chose these specific options based on the UI design requirements in the 
scope of work, but I see the value in aligning with all backend-supported 
aggregation functions for better reusability.Wondering what is the best 
solution/hybrid approach for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to