Antonio-RiveroMartnez commented on code in PR #32767:
URL: https://github.com/apache/superset/pull/32767#discussion_r2010267751
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/buildQuery.ts:
##########
@@ -47,5 +48,19 @@ export default function buildQuery(formData: QueryFormData) {
flattenOperator(formData, baseQueryObject),
],
},
+
+ {
Review Comment:
Do we need this block here or is it OK just to include the new
`aggregationOperator` in the list above after or before the `flattenOperator`
if teh value is not `LAST_VALUE`?
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/buildQuery.ts:
##########
@@ -47,5 +48,19 @@ export default function buildQuery(formData: QueryFormData) {
flattenOperator(formData, baseQueryObject),
],
},
+
+ {
Review Comment:
Do we need this block here or is it OK just to include the new
`aggregationOperator` in the list above after or before the `flattenOperator`
if the value is not `LAST_VALUE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
