JZ6 commented on PR #32969: URL: https://github.com/apache/superset/pull/32969#issuecomment-2773024911
> This seems like it's a great idea, but it does seem like it might need a SIP to answer any questions that come up. I'll seed the discussion with a few: • We have had this feature in our deployment of superset for 2 years now, so I may be able to answer some of these questions based on how we have handled this: Will there be a migration to convert all pre-existing charts to "Published" when this launches? Ideally old charts should stay as draft, but maybe add a way for admins to bulk publish multiple/all charts at once? • If a chart is un-published, does it still appear in dashboards it was placed in? If not, how does it fail gracefully? Perhaps a chart in a published dashboard can not be unpublished unless the dashboard is also in draft. We also have checks the other way, a dashboard can only be published if all charts within is published Who has the RBAC permissions to publish/unpublish a chart? The owner(s) of the chart, and admins, I presume? We use a seperate role with special publish perms, but yes only allowing owners and admins would make sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org