michael-s-molina commented on PR #32969: URL: https://github.com/apache/superset/pull/32969#issuecomment-2773332069
My 2 cents: - The number of questions raised in this thread and the number of open questions are a clear indication of a SIP. - I don't think we should use feature flags to think about new features as we code. Feature flags introduce conditions into the core codebase, increase complexity, and maintainability. If we don't know yet the extent of this feature, I would suggest creating a feature branch. We're doing this with [Theming](https://github.com/apache/superset/pull/31590) and [Extensions](https://github.com/apache/superset/pull/31934) for example. - In my opinion, feature flags should be used when we already discussed the feature over a SIP and we use a feature flag to develop what was agreed. Not to think about the feature while modifying the core codebase. - Introducing feature flags in PRs without any SIP was the reason for many poorly designed features that we had to re-implement is the past. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
