villebro commented on PR #32969: URL: https://github.com/apache/superset/pull/32969#issuecomment-2773363332
@ethan-liong as part of [SIP-152](https://github.com/apache/superset/issues/32116), we're introducing the concept of Viewers to Charts and Dashboards. This means, that once rolled out, Draft/Published is redundant, as read only access will be provided by assigning subjects as Viewers. See my comment https://github.com/apache/superset/issues/32116#issuecomment-2643567384 , more specifically this bullet: > - We replace all owner references with the new Subject model that can be a User, Group or Role. This covers Dashboards, Charts, Datasets and Alerts & Reports. > - We introduce the Viewer property to Dashboard and Chart entities (for Alerts & Reports having a Viewer is not very useful). During the migration we map all Dashboard RBAC roles as Viewers and remove the DASHBOARD_RBAC feature flag. > - We map Roles that have implicit access to Dashboards and Charts to their respective Viewer property, and remove the implicit dashboard/chart access control logic. However, for Dashboards that are in Draft state we leave the Viewer property empty. Finally we remove the "published" property from the Dashboard model, and remove the Draft/Published pill (good riddance!). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
