payose opened a new pull request, #32980:
URL: https://github.com/apache/superset/pull/32980

   ###SUMMARY
   This PR upgrades the Checkbox component to Ant Design v5, aligning with the 
ongoing effort to update the UI library. The previous implementation relied on 
a customized checkbox that did not fully leverage Ant Design's built-in 
component. This update ensures consistency, improves maintainability, and 
removes unnecessary custom styling.
   
   ###Scope of work:
   -Refactored src/components/Checkbox to use the Ant Design 5 Checkbox 
component.
   -Refactored src/components/IndeterminateCheckbox to align with the Ant 
Design v5 update.
   -Removed AntdCheckbox export from superset-frontend/src/components/index.ts.
   -Updated all direct imports of Checkbox from Ant Design to use 
src/components/Checkbox.
   -Removed unnecessary custom styles in favour of Ant Design defaults.
   -Ensured proper RTL support and test coverage.
   -Updated the Storybook entry to cover all relevant component options for 
Checkbox and IndeterminateCheckbox.
   
   
   ###TESTING INSTRUCTIONS
   
   Run the application and navigate to a UI section using the Checkbox 
component.
   Verify that the updated Checkbox functions correctly and matches Ant Design 
v5 styling.
   Run unit tests and ensure they pass.
   Verify RTL behavior for the Checkbox.
   Check Storybook to ensure the updated component is correctly documented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to