kasiazjc commented on PR #33054: URL: https://github.com/apache/superset/pull/33054#issuecomment-2796656866
> Should we leverage the Select option to render custom elements within the Select itself? The checkbox could be part of the Dropdown in the Select to avoid taking unnecessary space on the filters. > >  @geido I think this is a good catch in terms of creating a new values + in terms of inverse selection I think showing a dynamic control could be a solution in here. So we would keep our normal inverse selection filter and then, when the filter is checked, you would see a second checkbox with something like "show dynamic inverse selection in the dashboard" @michael-s-molina good point that it's a duplicate, but where it came from we found that users sometimes would prefer using excluding in terms of including values and it's not easily accessible - and only to admins. This doesn't really affect things like security etc, so we thought that it's a good idea to bring it to dashboard filters section. In terms of design - I can see how checkbox can take up a lot of space, so here is the second proposal that I had before in the designs <img width="166" alt="image" src="https://github.com/user-attachments/assets/98503411-5423-4d2f-8966-62db98909a21"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
