amaannawab923 commented on PR #33054: URL: https://github.com/apache/superset/pull/33054#issuecomment-2796943473
> Should we leverage the Select option to render custom elements within the Select itself? The checkbox could be part of the Dropdown in the Select to avoid taking unnecessary space on the filters. > >  This one makes much more sense , it doesnt occupy space and doesnt bring major ui changes which might rather break As mentioned by @kgabryje , Inverse selection and this dynamic checkbox are both redundant .... so we rename inverse selection to dynamic inverse selection which makes this checkbox appear of "Exclude filter values" & we do not keep the new config of "Show dynamic exclusion selection field" to avoid redundancy So the ideal flow can be 1. Enable Dynamic Inverse selection which makes the checkbox of exclude filter values appear 2. Keep true by default 3.Toggling it will basically go back & forth to NOT IN and IN operator This flow will be straightforward and wont confuse end users ...Awaiting for feedback @geido @kasiazjc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
