michael-s-molina commented on PR #33054:
URL: https://github.com/apache/superset/pull/33054#issuecomment-2797335623

   > we found that users sometimes would prefer using excluding in terms of 
including values and it's not easily accessible
   
   I agree the user need is pretty clear.
   
   I think @amaannawab923 proposal makes sense:
   
   > Enable Dynamic Inverse selection which makes the checkbox of exclude 
filter values appear
   > Keep true by default
   > Toggling it will basically go back & forth to NOT IN and IN operator
   
   In this context, my observations would be:
   - Do we really need the `Enable Dynamic Inverse selection` or should we 
always present the checkbox in the filter so users can dynamically change 
between IN / NOT IN?
   - We also need to think about how to migrate existing filters that currently 
have `Inverse selection` checked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to