Re: [PR] refactor(Table): Use Table instead of html in CollectionTable [superset]

Tue, 22 Apr 2025 08:04:58 -0700


EnxDev commented on code in PR #33159:
URL: https://github.com/apache/superset/pull/33159#discussion_r2054309663


##########
superset-frontend/src/components/Datasource/CollectionTable.tsx:
##########
@@ -113,6 +56,32 @@ const StyledButtonWrapper = styled.span`
   `}
 `;
 
+type CollectionItem = { id: string | number; [key: string]: any };

Review Comment:
   Would it be possible to define a more specific type here if we had better 
knowledge of the properties, to avoid `any` type?
   
   I noticed there are quite a few other `any` types in the code — can we try 
to avoid them as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to