mistercrunch commented on code in PR #33159:
URL: https://github.com/apache/superset/pull/33159#discussion_r2060560849
##########
superset-frontend/src/components/Datasource/CollectionTable.tsx:
##########
@@ -113,6 +56,32 @@ const StyledButtonWrapper = styled.span`
`}
`;
+type CollectionItem = { id: string | number; [key: string]: any };
Review Comment:
Yeah I think that's fine. The original intent when I built this a long time
ago was for it to become the basis for all CRUD in the app, but ended up going
a different way. If anything in the future, we'd remove this base component and
go more towards what other CRUDs are using, if that makes sense. For now we'll
flag as "needs refactor" and can do minimal edits to get theming through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
