msyavuz commented on code in PR #33159:
URL: https://github.com/apache/superset/pull/33159#discussion_r2057998056
##########
superset-frontend/src/components/Datasource/CollectionTable.tsx:
##########
@@ -113,6 +56,32 @@ const StyledButtonWrapper = styled.span`
`}
`;
+type CollectionItem = { id: string | number; [key: string]: any };
Review Comment:
I need generics for this type but the only component that uses this is jsx
so generics don't do anything. But we should definitely consider replacing
these with proper types when DatasourceEditor is typescript
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
