Vitor-Avila commented on PR #33196: URL: https://github.com/apache/superset/pull/33196#issuecomment-2826323084
@LevisNgigi my last comment was longer just to highlight the testing scenarios and flows, but to summarize, these are the remaining issues: * Big Numbers created prior to [the `subtitle` PR](https://github.com/apache/superset/pull/32975) show the subheader text duplicated. * Accessing the chart directly in Explore does not carry over the `subtitle` config (both text and size). To easily repro this: 1. Spin up Superset in dev mode. 2. Check out to commit `164a07e2be7854520070a7d845eec449405c4840`. 3. Create a dashboard including one Big Number for each subheader size available. For example: <img width="1783" alt="image" src="https://github.com/user-attachments/assets/16d1b0ac-9d91-4356-b6de-a83fef5b7b52"; /> 4. Checkout to this branch. 5. Refresh the dashboard: <img width="1789" alt="image" src="https://github.com/user-attachments/assets/f757f08b-43f9-4a21-82ae-6c5572030e50"; /> 6. Accessing a chart from this dashboard does not show the subtitle config: <img width="1331" alt="image" src="https://github.com/user-attachments/assets/9f138c6d-49c1-4a5f-bba1-00e4806e5aa5"; /> Let me know if you have any questions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
