michael-s-molina commented on code in PR #33146:
URL: https://github.com/apache/superset/pull/33146#discussion_r2072041881
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/controlPanel.tsx:
##########
@@ -39,6 +40,48 @@ const config: ControlPanelConfig = {
['metric'],
['adhoc_filters'],
['row_limit'],
+ [
+ {
+ name: 'seriesOrderByColumn',
+ config: {
+ type: 'SelectControl',
+ label: t('Order Series By Column'),
+ description: t(
+ 'Column to use for ordering the waterfall series with columns
not in the chart',
+ ),
+ mapStateToProps: state => ({
+ choices: [
+ ...(state.datasource?.columns || []).map(col => [
+ col.column_name,
+ col.column_name,
+ ]),
+ ],
+ default: state.form_data?.x_axis || '',
Review Comment:
This control can't be empty because it will throw an error when executing
the query. It should appear only when the controls it depends on as filled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
