sadpandajoe commented on code in PR #34091: URL: https://github.com/apache/superset/pull/34091#discussion_r2191189300
########## superset/config.py: ########## @@ -1392,6 +1392,17 @@ def engine_context_manager( # pylint: disable=unused-argument } +# --------------------------------------------------- +# ClickHouse-connect driver settings +# --------------------------------------------------- +# Enable or disable automatic column-label mutation in the clickhouse-connect driver. +# When True (the default), the driver will rename duplicate or conflicting labels +# for backward compatibility. When False, labels are left exactly as defined— +# necessary if your ClickHouse query refers to its own aliases within the same SELECT. +CLICKHOUSE_CONNECT_ENABLE_LABEL_MUTATION: bool = True Review Comment: @joe-clickhouse how does it work now without this flag? That should be the default state as it won't surprise anyone that upgrades to the next version of superset. So if currently we don't rename labels then that should be the default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
