mistercrunch commented on PR #34091: URL: https://github.com/apache/superset/pull/34091#issuecomment-3050262996
Why allowing both through config? Shouldn't this be one or the other - whichever works or works best? Overall I'm not big on adding database-engine-specific configs in `superset/config.py`. If indeed we need both, could this be done as a database connection flag, maybe something in the connection's `extra` field (which is used to cover the long tail of database connection attributes)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
