joe-clickhouse commented on code in PR #34091: URL: https://github.com/apache/superset/pull/34091#discussion_r2191203610
########## superset/config.py: ########## @@ -1392,6 +1392,17 @@ def engine_context_manager( # pylint: disable=unused-argument } +# --------------------------------------------------- +# ClickHouse-connect driver settings +# --------------------------------------------------- +# Enable or disable automatic column-label mutation in the clickhouse-connect driver. +# When True (the default), the driver will rename duplicate or conflicting labels +# for backward compatibility. When False, labels are left exactly as defined— +# necessary if your ClickHouse query refers to its own aliases within the same SELECT. +CLICKHOUSE_CONNECT_ENABLE_LABEL_MUTATION: bool = True Review Comment: Before this PR, the behavior was to always mutate the labels. With the PR, the default (with no user intervention) will be the same--always mutate labels. If the flag is missing from `config.py` and/or the user's `supserset_config.py` the default behavior will also be to always mutate the labels. The only condition under which behavior will change will be if the user sets this flag to `False`--then the labels will _not_ be mutated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
