mistercrunch commented on code in PR #34051:
URL: https://github.com/apache/superset/pull/34051#discussion_r2201852818
##########
superset-frontend/src/preamble.ts:
##########
@@ -26,6 +26,20 @@ import setupFormatters from './setup/setupFormatters';
import setupDashboardComponents from './setup/setupDashboardComponents';
import { User } from './types/bootstrapTypes';
import getBootstrapData, { applicationRoot } from './utils/getBootstrapData';
+import 'dayjs/locale/en';
Review Comment:
What's the reason for moving this from
`superset-frontend/src/hooks/useLocale.ts` to this location? I'm almost
wondering if we should try to hot-load this using a dynamic import in webpack
so there's no penaltly on always loading all languages and bringing this all in
package/memory in the browser. Ideally webpack would prepare one bundle for
each language and only load the language that's needed for the current user ...
It was already this way, but maybe that's an opportunity to improve things
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
