mistercrunch commented on code in PR #34051:
URL: https://github.com/apache/superset/pull/34051#discussion_r2201863696


##########
superset/models/helpers.py:
##########
@@ -544,13 +545,28 @@ def changed_on_utc(self) -> str:
         # Convert naive datetime to UTC
         return 
self.changed_on.astimezone(pytz.utc).strftime("%Y-%m-%dT%H:%M:%S.%f%z")
 
+    def _format_time_humanized(self, timestamp: datetime) -> str:

Review Comment:
   Seems this improvement should be backend only (?) I'm wondering why we need 
to touch the frontend at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to