mistercrunch commented on code in PR #34051: URL: https://github.com/apache/superset/pull/34051#discussion_r2201881300
########## superset/models/helpers.py: ########## @@ -103,6 +103,7 @@ VIRTUAL_TABLE_ALIAS = "virtual_table" SERIES_LIMIT_SUBQ_ALIAS = "series_limit" ADVANCED_DATA_TYPES = config["ADVANCED_DATA_TYPES"] +DEFAULT_LOCALE = "en" Review Comment: Not sure if this is the right spot for this constant ... Seems we use `get_locale()` in a least one other place (superset/views/base.py). Oh actually I just found `BABEL_DEFAULT_LOCALE` in https://github.com/apache/superset/blob/master/superset/config.py#L378 , you should use that instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
