Re: [PR] fix(theming): Theming visual fixes [superset]

Mon, 21 Jul 2025 13:58:56 -0700 


korbit-ai[bot] commented on code in PR #34253:
URL: https://github.com/apache/superset/pull/34253#discussion_r2220324604


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx:
##########
@@ -74,14 +73,10 @@ const verticalStyle = (theme: SupersetTheme, width: number) 
=> css`
   padding-top: ${theme.sizeUnit * 6}px;
 
   background: linear-gradient(
-    ${rgba(theme.colors.grayscale.light5, 0)},
-    ${theme.colors.grayscale.light5} 60%
+    ${rgba(theme.colorBgLayout, 0)},
+    ${theme.colorBgElevated} 20%
   );

Review Comment:
   ### Unexplained Magic Number in Gradient <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The magic number 20% in the gradient is hardcoded without explanation of its 
significance.
   
   
   ###### Why this matters
   Unexplained magic numbers make it difficult to understand the design 
decisions and complicate future adjustments to the UI.
   
   ###### Suggested change ∙ *Feature Preview*
   Extract the number into a named constant or add a comment explaining its 
purpose:
   ```typescript
   const GRADIENT_STOP_PERCENTAGE = 20;
   // Gradient fades in over the first 20% for smooth visual transition
   background: linear-gradient(
     ${rgba(theme.colorBgLayout, 0)},
     ${theme.colorBgElevated} ${GRADIENT_STOP_PERCENTAGE}%
   );
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c522370e-3cc7-4af3-93c7-df2b54586598/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c522370e-3cc7-4af3-93c7-df2b54586598?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c522370e-3cc7-4af3-93c7-df2b54586598?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c522370e-3cc7-4af3-93c7-df2b54586598?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c522370e-3cc7-4af3-93c7-df2b54586598)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:debd42d8-c226-4a56-8a51-dfdd195c92db -->
   
   
   [](debd42d8-c226-4a56-8a51-dfdd195c92db)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to