msyavuz commented on code in PR #34253:
URL: https://github.com/apache/superset/pull/34253#discussion_r2223769800
##########
superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx:
##########
@@ -134,6 +133,11 @@ export function Button(props: ButtonProps) {
'& > span > :first-of-type': {
marginRight: firstChildMargin,
},
+ ':not(:hover)': effectiveButtonStyle === 'secondary' && {
+ // Increase contrast for secondary buttons
+ backgroundColor:
`${tinycolor(theme.colorPrimaryBg).darken(2).toHexString()} !important`,
Review Comment:
I looked into this but using colorPrimaryHover or Border for the background
of secondary button seemed off semantically. Do you think it's better than
using lighten/darken?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
