mistercrunch commented on PR #34253: URL: https://github.com/apache/superset/pull/34253#issuecomment-3104857375
> I think we might need to extend the framework for buttons specifically since we are customizing it so much to our needs. Curious what semantic you would introduce? something like `colorPrimaryBgSecondary`? Noting that it might be a bit of a mess since the `darkAlgorithm` is what generates a lot of the shading with builtin logic. Might be better to establish design contraints, telling @kasiazjc she has to work with the shades/tokens in the framework (?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
