msyavuz commented on PR #34253: URL: https://github.com/apache/superset/pull/34253#issuecomment-3104890718
If we need a secondary button we can introduce seed tokens for it and extend the algorithm to produce necessary map tokens (in the default themes). `colorSecondary` `colorSecondaryBg` etc. It will mean diversion from Antd but we already do that. Also since user's will use Ant Design's theme editor to customize their theme, none of the options seem good enough: 1. Introduce `colorSecondary` as a seed token: Doesn't exist on the theme editor 2. Use semantically incorrect tokens: Unexpected colors that doesn't reflect in theme editor. 3. Lighten/Darken: Same thing as the first one but smaller impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
