rusackas commented on issue #33448: URL: https://github.com/apache/superset/issues/33448#issuecomment-3198594774
> I would Abstract the query-only controls into a mode="simple" variant of Explore, so we reuse the same building blocks and avoid duplication. I think the key is that we _don't_ fork the Explore code. It's complex enough as-is, and having diverging variants of it sounds like a maintenance nightmare. I would hope now that we're in a React SPA, that Explore could itself be a mega-component, and be fed the correct state/context through Redux/React Content/Props (whatever works). Then step two would be adding a "simple mode" prop to take away extraneous controls/UI. Then, in theory, that Explore component (simplified or full-blown) could be used in a Modal in the dashboard setting, I would think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
