Vitor-Avila commented on code in PR #34388:
URL: https://github.com/apache/superset/pull/34388#discussion_r2299424809
##########
superset/commands/database/create.py:
##########
@@ -118,25 +111,23 @@ def run(self) -> Model:
) as ex:
event_logger.log_with_context(
action=f"db_creation_failed.{ex.__class__.__name__}",
- engine=database.db_engine_spec.__name__,
+ engine=engine,
)
raise DatabaseCreateFailedError() from ex
- if ssh_tunnel:
- stats_logger.incr("db_creation_success.ssh_tunnel")
-
return database
def validate(self) -> None:
Review Comment:
Does it make sense to validate in here if 1) the DB has an SSH config and 2)
the FF is disabled? This way we short-circuit early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
