Vitor-Avila commented on PR #34388:
URL: https://github.com/apache/superset/pull/34388#issuecomment-3222189039

   Performed these manual tests:
   1. Created a PSQL connection with SSH on `master`.
   2. Checked out to this branch.
   3. Confirmed the connection is still working.
   4. Deleted the bastion host on AWS.
   5. Confirmed the connection is no longer working.
   6. Updated the connection with the new EC2 info.
   7. Connection is back working.
   8. Tested creating a new connection -- works.
   
   @betodealmeida it's def not related with this PR, but wondering if you want 
to also tackle this. In the dynamic form, we have **Private Key Password** 
marked with `*` (required) even tho it's not (and it shouldn't be, as the 
private key might not have a password):
   <img width="507" height="425" alt="image" 
src="https://github.com/user-attachments/assets/9b4841ea-825a-4bd8-856d-aad2e16e4b66";
 />
   
   I also noticed some issues in which I would have all requires fields filled 
(except this one) and the Connect button would still be disabled, but then 
clicking on some fields would unblock the button. I think the validation is a 
bit flaky.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to