Vitor-Avila commented on code in PR #34388:
URL: https://github.com/apache/superset/pull/34388#discussion_r2299426739
##########
superset/commands/database/test_connection.py:
##########
@@ -108,33 +109,37 @@ def run( # noqa: C901
)
)
+ # collect SSH tunnel info
+ ssh_tunnel_properties = self._properties.get("ssh_tunnel")
+ if ssh_tunnel_properties and self._model and self._model.ssh_tunnel:
+ # unmask password while allowing for updated values
+ ssh_tunnel_properties = unmask_password_info(
+ ssh_tunnel_properties,
+ self._model.ssh_tunnel,
+ )
+
+ database: Database | None = None
Review Comment:
Here as well -- do we want to have a server-side validation that SSH FF is
enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
