mistercrunch commented on PR #35259: URL: https://github.com/apache/superset/pull/35259#issuecomment-3330956871
A tiny bit concerned about having `superset-core` treated (explicitely or implicitely) as a wide public API and the change management concerns that come with that. To help manage that, I'd propose that we: - use python convention for private/public (`_method`= you probably shouldn't use that if care about easy upgrade, this is meant for the internal ecosystem) and `__method` -> definitely don't want to use that, even in the ecosystem/monorepo - actively reduce the API surface, go through all the methods and "privatize" what's not essential in the public API - make superset-core pre-1.0 and allow ourselves to break API and privatize things until 1.0 is officially out. From that point onwards we do proper semver/change-management on public methods/objects/properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
