michael-s-molina commented on PR #35259:
URL: https://github.com/apache/superset/pull/35259#issuecomment-3335040560
> A tiny bit concerned about having superset-core treated (explicitely or
implicitely) as a wide public API and the change management concerns that come
with that.
@mistercrunch I share the same concerns as you and this is one of the
motivations for exposing only the API definitions in `superset-core` without
any implementation or private methods. In essence, the APIs should only contain
public methods that we will support with semver. Any private method will not be
part of `superset-core` and will be defined at the host implementation. For
example:
```
ISomeDAO: (superset-core)
@abstractmethod
def public_function():
...
SomeDAO(ISomeDAO): (host)
def public_function():
... implementation logic
def private_function():
... implementation logic
```
> make superset-core pre-1.0 and allow ourselves to break API and privatize
things until 1.0 is officially out. From that point onwards we do proper
semver/change-management on public methods/objects/properties
That's exactly what we defined in the SIP and the reason we publish the
packages as 0.0.1-rcx in both NPM and PyPI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
