mistercrunch commented on PR #35259: URL: https://github.com/apache/superset/pull/35259#issuecomment-3335622463
> the APIs should only contain public methods but clearly there are useful bits/methods/objects that we want to use/reuse within `superset-core` but don't want to or don't need to expose as part of the public API. I say we just put an underscore in their name to signal they're not part of the public api. One example might be something like `_is_uuid_or_int(any_id: int | str)`, clearly it's something we need to use/reuse, but really no need to make that public... Python really lacking here, though doing it by convention with `_` and `__` prefix is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
