rusackas commented on code in PR #34762:
URL: https://github.com/apache/superset/pull/34762#discussion_r2441378997
##########
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx:
##########
@@ -339,6 +370,47 @@ export const FormattingPopoverContent = ({
</Row>
)}
</FormItem>
+ <Row style={{ display: 'flex', height: '40px' }}>
Review Comment:
Do we need the CSS here? We're hoping that using "vanilla" AntD components
means we don't need to provide style overrides... but if we do, maybe they
should be props for the Row component so that they're used systematically
wherever needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
