SBIN2010 commented on PR #34762: URL: https://github.com/apache/superset/pull/34762#issuecomment-3348693269
> I asked Claude about it, as well as a fourth option - doing it in transformProps. I think that makes more sense than adding the logic to the control panel, but I'm curious your opinion. Here's the [LLM thread](https://claude.ai/share/be55d469-32eb-41fd-938a-ebae71795ed0), for what it's worth. I agree with you that the best option without migrations would be to add processing to transformProps. However, this option doesn't solve the current problem, which can be formulated as follows: the missing flags need to be added when opening the conditional formatting "card." That's why I suggested adding flag handling to the controlPanel, which ensures that new flags are transferred to the conditional formatting "cards". For clarity, I'll attach screenshots of the processing in transformProps. <img width="1422" height="646" alt="Снимок экрана от 2025-09-29 22-18-13" src="https://github.com/user-attachments/assets/ad3b6070-8353-4e40-8eab-acbf84ba111f"; /> and controlPanel <img width="1454" height="669" alt="Снимок экрана от 2025-09-29 11-15-31" src="https://github.com/user-attachments/assets/ce15b669-d470-483a-93e4-3efa5c017e16"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
