rusackas commented on code in PR #34762:
URL: https://github.com/apache/superset/pull/34762#discussion_r2441381401
##########
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx:
##########
@@ -339,6 +370,47 @@ export const FormattingPopoverContent = ({
</Row>
)}
</FormItem>
+ <Row style={{ display: 'flex', height: '40px' }}>
+ {showOperatorFields && showToAllRow && (
+ <>
+ <Col span={1}>
+ <FormItem
+ name="toAllRow"
+ valuePropName="checked"
+ initialValue={toAllRow}
+ >
+ <Checkbox
+ onChange={event => setToAllRow(event.target.checked)}
+ checked={toAllRow}
+ />
+ </FormItem>
+ </Col>
+ <Col style={{ padding: '5px' }}>
Review Comment:
Same here... we shouldn't need to be changing the padding of Col components
in multiple places. If it doesn't work as "vanilla" then we should see if the
Col component itself need adjustment (or a new prop for certain contexts).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
