mistercrunch commented on code in PR #35220:
URL: https://github.com/apache/superset/pull/35220#discussion_r2371324552
##########
superset-frontend/src/pages/ThemeList/index.tsx:
##########
@@ -340,14 +360,28 @@ function ThemesList({
)}
{original.is_system_default && (
<Tooltip title={t('This is the system default theme')}>
- <Tag color="warning">
+ <Tag
+ color="warning"
+ css={theme => css`
+ display: flex;
+ align-items: center;
+ gap: ${theme.sizeUnit}px;
+ `}
+ >
<Icons.SunOutlined /> {t('Default')}
</Tag>
</Tooltip>
)}
{original.is_system_dark && (
<Tooltip title={t('This is the system dark theme')}>
- <Tag color="default">
+ <Tag
+ color="default"
Review Comment:
NIT: repeating the lines above, wondering the elegant way to do this. Maybe
either `marginRight` on that first one or [maybe better] wrapping both into
`<Space size="small" style={{ display: 'inline-flex' }}>` might be most
antd-aligned, style-free. I think it'll generate and empty div but that's
probably ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
