mistercrunch commented on code in PR #35220:
URL: https://github.com/apache/superset/pull/35220#discussion_r2376802916
##########
superset-frontend/packages/superset-ui-core/src/components/Typography/Typography.test.tsx:
##########
@@ -50,7 +50,7 @@ describe('Typography Component', () => {
it('renders strong text', () => {
render(<Typography.Text strong>Strong Text</Typography.Text>);
- expect(screen.getByText('Strong Text')).toHaveStyle('font-weight: 500');
+ expect(screen.getByText('Strong Text')).toHaveStyle('font-weight: 600');
Review Comment:
Oh, then I'm surprised we don't have more unit tests failing. Noting this
test doesn't seem to use the spec/helpers/ render (which renders with a theme
provider), it does `import '@testing-library/jest-dom';` instead of
`@superset-ui/core/spec`, wondering if it has something to do with it.
Sidetrack (outside the scope of this PR): It's a bit of a mess around this,
might be good to not allow importing `@testing-library` directly so we're
always providing a theme context. It's a bit confusing since each library might
have slightly different helpers (useRedux:true in main app for instance).
Not sure what to do with all this, maybe it's just out-of-scope of this PR
and this change is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
