gabotorresruiz commented on code in PR #35220:
URL: https://github.com/apache/superset/pull/35220#discussion_r2391856883
##########
superset/daos/theme.py:
##########
@@ -45,27 +45,14 @@ def find_system_default(cls) -> Optional[Theme]:
if len(system_defaults) == 1:
return system_defaults[0]
- if len(system_defaults) > 1:
- logger.warning(
- "Multiple system default themes found (%s), "
- "falling back to config theme",
- len(system_defaults),
- )
-
- # Fallback to is_system=True theme with name 'THEME_DEFAULT'
- return (
- db.session.query(Theme)
- .filter(Theme.is_system.is_(True), Theme.theme_name ==
"THEME_DEFAULT")
- .first()
- )
+ return None
Review Comment:
it was intentionally simplified. Returning `None` causes the system to use
the `config.py` themes as fallback, which is the desired behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
