bito-code-review[bot] commented on PR #35886:
URL: https://github.com/apache/superset/pull/35886#issuecomment-3461306273
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram">Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant ReduxStore as Redux Store
participant DashboardContainer as DashboardContainer<br/>🔄 Updated | ●●● High
participant useSelector as useSelector Hook
participant useEffect as useEffect Hook<br/>🔄 Updated | ●●○ Medium
participant setInScopeStatusOfFilters as setInScopeStatusOfFilters
Action<br/>🔄 Updated | ●●○ Medium
participant Dispatcher as Redux Dispatcher
participant DashboardInfo as DashboardInfo Reducer
Note over ReduxStore, DashboardContainer: Native filters state
change<br/>triggers dependency re-evaluation
ReduxStore->>useSelector: Provide nativeFilters state
useSelector->>DashboardContainer: Return filters & scopes
DashboardContainer->>useEffect: Execute with updated dependencies
useEffect->>setInScopeStatusOfFilters: Calculate filter scopes
setInScopeStatusOfFilters->>Dispatcher: Dispatch scope status action
Dispatcher->>DashboardInfo: Update dashboard metadata
DashboardInfo-->>ReduxStore: Persist filter scope changes
```
Critical path: Redux Store->useSelector
Hook->DashboardContainer->useEffect Hook->setInScopeStatusOfFilters
Action->Dispatcher->DashboardInfo Reducer
> **Note:** The change adds native filter state tracking to the useEffect
dependency array, ensuring the dashboard recalculates filter scopes whenever
native filters change. This prevents stale filter scope data and improves
consistency between filter configuration and their dashboard impact.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]