richardfogaca commented on code in PR #35886:
URL: https://github.com/apache/superset/pull/35886#discussion_r2481474119
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx:
##########
@@ -192,7 +204,14 @@ const DashboardContainer: FC<DashboardContainerProps> = ({
topLevelTabs }) => {
};
});
dispatch(setInScopeStatusOfFilters(scopes));
- }, [chartIds, JSON.stringify(nativeFilterScopes), dashboardLayout,
dispatch]);
+ // eslint-disable-next-line react-hooks/exhaustive-deps
Review Comment:
yes thanks @msyavuz actually these changes did not solve the issue so I
removed them. The change that fixes the issue is in nativeFilters.ts file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
