amaannawab923 commented on code in PR #35886:
URL: https://github.com/apache/superset/pull/35886#discussion_r2477560163
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx:
##########
@@ -192,7 +195,13 @@ const DashboardContainer: FC<DashboardContainerProps> = ({
topLevelTabs }) => {
};
});
dispatch(setInScopeStatusOfFilters(scopes));
- }, [chartIds, JSON.stringify(nativeFilterScopes), dashboardLayout,
dispatch]);
+ }, [
+ chartIds,
+ JSON.stringify(nativeFilterScopes),
+ dashboardLayout,
+ dispatch,
+ JSON.stringify(nativeFilters),
Review Comment:
Json.stringify is usually quite a performance tradeoff in useEffect
dependancies , is it possible to get some memoised variable which we can use
here like
hasNativeFiltersChanged = useMemo(() => {
prevNativeFilters !== currentNativeFilters
})
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
