kasiazjc commented on PR #36239: URL: https://github.com/apache/superset/pull/36239#issuecomment-3601976909
> Great work! I especially LOVE the way reordering now visually shows how the columns/metrics shuffle around (compared to how the controls work). However, while playing around with this, one critique I have is that while it's great that you can reorder controls/metrics as you wish into folders, we currently don't distinguish between controls and metrics like we do in the dataset panel: <img alt="image" width="618" height="872" src="https://private-user-images.githubusercontent.com/33317356/521003041-e89b3711-21fa-4b88-a671-8af11af810d8.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjQ2ODEwMDcsIm5iZiI6MTc2NDY4MDcwNywicGF0aCI6Ii8zMzMxNzM1Ni81MjEwMDMwNDEtZTg5YjM3MTEtMjFmYS00Yjg4LWE2NzEtOGFmMTFhZjgxMGQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjAyVDEz MDUwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVjNTA4Y2IyM2JkMDU2N2Y1ZTJlOWYwMzQ1YTlmYjRiM2YwOWVlNTBlMmJjZmZjMGJkYmZjNGJkYTEyOTM1MDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.V1_XJipAaJNSdwmgYBkY2zeiXz6BudX32Dl13uWB14U"> > > Here in the **test** folder we're mixing both metrics and columns, which can be very confusing, especially if you have lots of them. I don't have a great proposal for fixing this, but a few things come to mind: > > 1. Maintaining separate columns and metrics within the folder view, like we currently do for un-foldered columns/metrics. This would clarify which is which, but as a downside, it'll eat up more real estate. > 2. Have a folder selector above the metrics/columns section in the dataset panel, which would then act as a filter for the columns/metrics sections below. This would maintain the current UX, but as a downside, you wouldn't have the same freedom of browsing or reorganizing columns/metrics. > 3. Change the labels of the columns/metrics to clearly show what type of elements they are. This would disambiguate them, but would maybe add more overhead in terms of having the new icon/indicator on each element. > > Also, when folders are defined, I wonder if we should just dump un-foldered columns/metrics under an "Undefined" folder which would be the last top level folder in the tree. > > Unfortunately I don't have any great solutions here, just bad options.. @kasiazjc do you have any thoughts on how to harmonize the folder view with the current UX? Thanks Ville for feedback ❤️ > 1. Maintaining separate columns and metrics within the folder view, like we currently do for un-foldered columns/metrics. This would clarify which is which, but as a downside, it'll eat up more real estate. We were thinking about doing this, also to simplify the flow, but we decided (also based on feedback) that it would be too restrictive, especially because in the end people wanted more freedom in folder creation. I am thinking about a solution that would kinda combine things you were suggesting, so: 1. Change calculated column or metrics icon to better reflect the type of the item - do you maybe have an idea which icon would work better? I always struggle a bit with this :) We also have item type on hover, which while not perfect will help people learn what icons mean. 2. Add filter at the top of the list in: - dataset panel - folders tab This would allow users to filter via the item type (we could even do different types of columns with multiselect). I think this would help with browsing too and could be inline with search. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
