codeant-ai-for-open-source[bot] commented on PR #36239: URL: https://github.com/apache/superset/pull/36239#issuecomment-3655790615
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36239/files#diff-70e1158be5964ddd043e501987b98185d92295d6b41c62acd31771023bb68296R20-R28'><strong>Missing React type import</strong></a><br>The prop type for `onSearch` references `React.ChangeEvent<HTMLInputElement>` but `React` (or the `ChangeEvent` type) is not imported. This will cause a TypeScript compile error ("Cannot find namespace 'React'"). Add a type-only import or import React so the type resolves.<br> - [ ] <a href='https://github.com/apache/superset/pull/36239/files#diff-538318ab7b5bc9b2d063752354d499b4f4f488a44e7f3203033b0ffd1377b1b8R245-R269'><strong>Cleanup data loss</strong></a><br>The implementation of cleanupFolders filters children to only folder-type entries when recursing, which discards metric/column children from folders — this will effectively drop items from the structure during cleanup.<br> - [ ] <a href='https://github.com/apache/superset/pull/36239/files#diff-538318ab7b5bc9b2d063752354d499b4f4f488a44e7f3203033b0ffd1377b1b8R151-R197'><strong>Non-recursive move/remove</strong></a><br>moveItems (removeItems/addItems) only operates on immediate children / top-level folders. It doesn't traverse nested folders to remove items from or add items into nested targets, so moves will fail for nested folder structures.<br> - [ ] <a href='https://github.com/apache/superset/pull/36239/files#diff-f43fd23d393b136221ac3d1e31daa9cf17c1c148f34fa6bb384c98dd4d1e1b79R177-R180'><strong>Payload contract</strong></a><br>The PR adds `payload.folders = datasource.folders` when the feature flag is enabled. Verify the exact shape that the backend expects for `folders` (array vs JSON string, required fields, id vs uuid, nested structure). Sending the wrong shape may silently fail to persist folder changes or cause backend validation errors. Consider normalizing / pruning the object to the minimal fields backend needs.<br> - [ ] <a href='https://github.com/apache/superset/pull/36239/files#diff-e11ab2c8f90e87326874de6f8f2f845a1b7ccc8e6cf208d7ad7a6951309ac7cbR20-R22'><strong>Possible export mismatch</strong></a><br>The file re-exports three components as named exports. If any of the target files (e.g. FoldersToolbarComponent, ResetConfirmModal, DragOverlayContent) use default exports instead of named exports, these re-exports will break the build. Verify the actual exports in those modules and ensure the re-export syntax matches (named vs default).<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
