rusackas commented on code in PR #36127:
URL: https://github.com/apache/superset/pull/36127#discussion_r2621558928
##########
superset-frontend/src/features/alerts/components/NotificationMethod.tsx:
##########
@@ -338,6 +338,8 @@ export const NotificationMethod:
FunctionComponent<NotificationMethodProps> = ({
((!isFeatureEnabled(FeatureFlag.AlertReportSlackV2) ||
useSlackV1) &&
method === NotificationMethodOption.Slack) ||
+ (isFeatureEnabled(FeatureFlag.AlertReportWebhook) &&
+ method === NotificationMethodOption.Webhook) ||
method === NotificationMethodOption.Email,
)
Review Comment:
Not to worried about feature flags needing memoization since we're following
patterns here and they get dealt with at boot time. Shouldn't be getting
flipped a lot :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
