Re: [PR] feat(reports): add webhook option for notifications [superset]

Mon, 15 Dec 2025 19:13:51 -0800 


rusackas commented on code in PR #36127:
URL: https://github.com/apache/superset/pull/36127#discussion_r2621597144


##########
superset/config.py:
##########
@@ -538,6 +538,7 @@ class D3TimeFormat(TypedDict, total=False):
     "ALERT_REPORT_TABS": False,
     "ALERT_REPORTS_FILTER": False,
     "ALERT_REPORT_SLACK_V2": False,
+    "ALERT_REPORT_WEBHOOK": False,

Review Comment:
   <h2 class="text-text-100 mt-3 -mb-1 text-[1.125rem] font-bold">Assessment: 
<strong>Not Valid</strong></h2>
   <p class="font-claude-response-body break-words whitespace-normal 
leading-[1.7]">Let me check the actual naming in the existing codebase from the 
diff:</p>
   <div class="relative group/copy bg-bg-000/50 border-0.5 border-border-400 
rounded-lg"><div class="sticky opacity-0 group-hover/copy:opacity-100 top-2 
py-2 h-12 w-0 float-right"><div class="absolute right-0 h-8 px-2 items-center 
inline-flex z-10"><button class="inline-flex
     items-center
     justify-center
     relative
     shrink-0
     can-focus
     select-none
     disabled:pointer-events-none
     disabled:opacity-50
     disabled:shadow-none
     disabled:drop-shadow-none border-transparent
             transition
             font-base
             duration-300
             ease-[cubic-bezier(0.165,0.85,0.45,1)] h-8 w-8 rounded-md 
active:scale-95 backdrop-blur-md Button_ghost__BUAoh" type="button" 
aria-label="Copy to clipboard" data-state="closed"><div class="relative"><div 
class="flex items-center justify-center transition-all opacity-100 scale-100" 
style="width: 20px; height: 20px;"><svg width="20" height="20" viewBox="0 0 20 
20" fill="currentColor" xmlns="http://www.w3.org/2000/svg"; class="shrink-0 
transition-all opacity-100 scale-100" aria-hidden="true"><path d="M12.5 
3C13.3284 3 14 3.67157 14 4.5V6H15.5C16.3284 6 17 6.67157 17 7.5V15.5C17 
16.3284 16.3284 17 15.5 17H7.5C6.67157 17 6 16.3284 6 15.5V14H4.5C3.67157 14 3 
13.3284 3 12.5V4.5C3 3.67157 3.67157 3 4.5 3H12.5ZM14 12.5C14 13.3284 13.3284 
14 12.5 14H7V15.5C7 15.7761 7.22386 16 7.5 16H15.5C15.7761 16 16 15.7761 16 
15.5V7.5C16 7.22386 15.7761 7 15.5 7H14V12.5ZM4.5 4C4.22386 4 4 4.22386 4 
4.5V12.5C4 12.7761 4.22386 13 4.5 13H12.5C12.7761 13 13 12.7761 13 12.5V4.5C13 
4.22386 12.7761 4 
 12.5 4H4.5Z"></path></svg></div><div class="flex items-center justify-center 
absolute top-0 left-0 transition-all opacity-0 scale-50" style="width: 20px; 
height: 20px;"><svg width="20" height="20" viewBox="0 0 20 20" 
fill="currentColor" xmlns="http://www.w3.org/2000/svg"; class="shrink-0 absolute 
top-0 left-0 transition-all opacity-0 scale-50" aria-hidden="true"><path 
d="M15.1883 5.10908C15.3699 4.96398 15.6346 4.96153 15.8202 5.11592C16.0056 
5.27067 16.0504 5.53125 15.9403 5.73605L15.8836 5.82003L8.38354 14.8202C8.29361 
14.9279 8.16242 14.9925 8.02221 14.9989C7.88203 15.0051 7.74545 14.9526 7.64622 
14.8534L4.14617 11.3533L4.08172 11.2752C3.95384 11.0811 3.97542 10.817 4.14617 
10.6463C4.31693 10.4755 4.58105 10.4539 4.77509 10.5818L4.85321 10.6463L7.96556 
13.7586L15.1161 5.1794L15.1883 
5.10908Z"></path></svg></div></div></button></div></div><div 
class="text-text-500 font-small p-3.5 pb-0">python</div><div><pre 
class="code-block__code !my-0 !rounded-lg !text-sm !leading-relaxed" style
 ="background: transparent; color: rgb(56, 58, 66); font-family: 
var(--font-mono); direction: ltr; text-align: left; white-space: pre; 
word-spacing: normal; word-break: normal; line-height: 1.5; tab-size: 2; 
hyphens: none; padding: 1em; margin: 0.5em 0px; overflow: auto; border-radius: 
0.3em;"><code class="language-python" style="background: transparent; color: 
rgb(56, 58, 66); font-family: var(--font-mono); direction: ltr; text-align: 
left; white-space: pre; word-spacing: normal; word-break: normal; line-height: 
1.5; tab-size: 2; hyphens: none;"><span><span class="token" style="color: 
rgb(160, 161, 167); font-style: italic;"># In superset/config.py - EXISTING 
flags:</span><span>
   </span></span><span><span></span><span class="token" style="color: rgb(80, 
161, 79);">"ALERT_REPORT_TABS"</span><span class="token" style="color: rgb(56, 
58, 66);">:</span><span> </span><span class="token" style="color: rgb(183, 107, 
1);">False</span><span class="token" style="color: rgb(56, 58, 
66);">,</span><span>
   </span></span><span><span></span><span class="token" style="color: rgb(80, 
161, 79);">"ALERT_REPORTS_FILTER"</span><span class="token" style="color: 
rgb(56, 58, 66);">:</span><span> </span><span class="token" style="color: 
rgb(183, 107, 1);">False</span><span class="token" style="color: rgb(56, 58, 
66);">,</span><span>
   </span></span><span><span></span><span class="token" style="color: rgb(80, 
161, 79);">"ALERT_REPORT_SLACK_V2"</span><span class="token" style="color: 
rgb(56, 58, 66);">:</span><span> </span><span class="token" style="color: 
rgb(183, 107, 1);">False</span><span class="token" style="color: rgb(56, 58, 
66);">,</span><span>
   </span></span><span><span></span><span class="token" style="color: rgb(80, 
161, 79);">"ALERT_REPORT_WEBHOOK"</span><span class="token" style="color: 
rgb(56, 58, 66);">:</span><span> </span><span class="token" style="color: 
rgb(183, 107, 1);">False</span><span class="token" style="color: rgb(56, 58, 
66);">,</span><span>  </span><span class="token" style="color: rgb(160, 161, 
167); font-style: italic;"># NEW - matches SLACK_V2 
pattern</span></span></code></pre></div></div>
   <p class="font-claude-response-body break-words whitespace-normal 
leading-[1.7]">The naming is <strong>already inconsistent</strong> in the 
existing codebase. The new flag <code class="bg-text-200/5 border border-0.5 
border-border-300 text-danger-000 whitespace-pre-wrap rounded-[0.4rem] px-1 
py-px text-[0.9rem]">ALERT_REPORT_WEBHOOK</code> actually follows the same 
pattern as:</p>
   <ul class="[li_&amp;]:mb-0 [li_&amp;]:mt-1.5 [li_&amp;]:gap-1.5 
[&amp;:not(:last-child)_ul]:pb-1 [&amp;:not(:last-child)_ol]:pb-1 list-disc 
flex flex-col gap-2 pl-8 mb-3">
   <li class="whitespace-normal break-words pl-2"><code class="bg-text-200/5 
border border-0.5 border-border-300 text-danger-000 whitespace-pre-wrap 
rounded-[0.4rem] px-1 py-px text-[0.9rem]">ALERT_REPORT_SLACK_V2</code> 
(singular)</li>
   <li class="whitespace-normal break-words pl-2"><code class="bg-text-200/5 
border border-0.5 border-border-300 text-danger-000 whitespace-pre-wrap 
rounded-[0.4rem] px-1 py-px text-[0.9rem]">ALERT_REPORT_TABS</code> 
(singular)</li>
   </ul>
   <hr class="border-border-200 border-t-0.5 my-3 mx-1.5">
   <p class="font-claude-response-body break-words whitespace-normal 
leading-[1.7]"><strong>More importantly, the flag is used consistently within 
this PR:</strong></p>
   <div class="overflow-x-auto w-full px-2 mb-6">
   Location | Value Used
   -- | --
   config.py | "ALERT_REPORT_WEBHOOK"
   featureFlags.ts | AlertReportWebhook = 'ALERT_REPORT_WEBHOOK'
   NotificationMethod.tsx | FeatureFlag.AlertReportWebhook
   webhook.py | is_feature_enabled("ALERT_REPORT_WEBHOOK")
   
   </div>
   <p class="font-claude-response-body break-words whitespace-normal 
leading-[1.7]">All references match. There's no bug here.</p>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to