rusackas commented on code in PR #36127: URL: https://github.com/apache/superset/pull/36127#discussion_r2621627088
########## superset/reports/notifications/webhook.py: ########## @@ -0,0 +1,140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import Any +from urllib.parse import urlparse + +import backoff +import requests +from flask import current_app + +from superset import feature_flag_manager +from superset.reports.models import ReportRecipientType +from superset.reports.notifications.base import BaseNotification +from superset.reports.notifications.exceptions import ( + NotificationParamException, + NotificationUnprocessableException, +) +from superset.utils import json +from superset.utils.decorators import statsd_gauge + +logger = logging.getLogger(__name__) + + +class WebhookNotification(BaseNotification): + """ + Sends a post request to a webhook url + """ + + type = ReportRecipientType.WEBHOOK + + def _get_webhook_url(self) -> str: + """ + Get the webhook URL from the recipient configuration + :returns: The webhook URL + :raises NotificationParamException: If the webhook URL is not provided in the recipient configuration + """ # noqa: E501 + try: + return json.loads(self._recipient.recipient_config_json)["target"] + except (json.JSONDecodeError, KeyError) as ex: Review Comment: Already fixed - line 208 now uses sample_rows is not None. The reviewer's comment is outdated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
