michael-s-molina commented on code in PR #36686:
URL: https://github.com/apache/superset/pull/36686#discussion_r2631041696
##########
superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts:
##########
@@ -31,7 +32,21 @@ export const getRelevantDataMask = (
Object.fromEntries(
Object.values(dataMask)
.filter(item => item[prop])
- .map(item => [item.id, item[prop]]),
+ .map(item => {
+ const value = item[prop];
Review Comment:
Shouldn't this be handled by the chart component instead of
`getRelevantDataMask`? I'm wondering if `clientView` might be useful for
another caller of `getRelevantDataMask` and should just be discarded by the
chart when re-rendering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
