sadpandajoe commented on code in PR #36686:
URL: https://github.com/apache/superset/pull/36686#discussion_r2632523077
##########
superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts:
##########
@@ -31,7 +32,21 @@ export const getRelevantDataMask = (
Object.fromEntries(
Object.values(dataMask)
.filter(item => item[prop])
- .map(item => [item.id, item[prop]]),
+ .map(item => {
+ const value = item[prop];
Review Comment:
I think modifying the table chart plugin (separate package) to conditionally
write `clientView` based on context could potentially be more complex and could
introduce regressions. Also this mirrors how `Explore` does it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
