codeant-ai-for-open-source[bot] commented on PR #36996: URL: https://github.com/apache/superset/pull/36996#issuecomment-3727244669
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36996/files#diff-72911db9b9a6a7361dbba666847f9c38fcb957d17448a364a718c7dfe021f881R359-R362'><strong>SSR / document usage</strong></a><br>The new getPopupContainer always references `document.body`. If this component is ever rendered during server-side rendering or in an environment without a DOM, accessing `document` may lead to runtime errors. Confirm the function is never executed during SSR or add a safe guard / fallback.<br> - [ ] <a href='https://github.com/apache/superset/pull/36996/files#diff-72911db9b9a6a7361dbba666847f9c38fcb957d17448a364a718c7dfe021f881R357-R363'><strong>Overlay placement implications</strong></a><br>Routing the popover to `document.body` prevents parent overflow/visibility issues but can change visual positioning, CSS scoping, and may affect styling that expects the overlay inside the same DOM subtree. Confirm overlayClassName rules still apply and that positioning is correct for all edge cases (scroll containers, fixed headers, or nested portals).<br> - [ ] <a href='https://github.com/apache/superset/pull/36996/files#diff-72911db9b9a6a7361dbba666847f9c38fcb957d17448a364a718c7dfe021f881R357-R357'><strong>Z-index consistency</strong></a><br>A hardcoded `zIndex: 1050` was introduced. Verify this value is consistent with the rest of the app and Ant Design modal/popover stacking context. Hardcoding may cause overlap issues in other contexts — consider centralizing or deriving the value from a theme/constant.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
